search

sindresorhus / github-markdown-css

The minimal amount of CSS to replicate the GitHub Markdown style
https://sindresorhus.com/github-markdown-css
MIT License
7.98k stars 2.1k forks source link

fix: don't break words in table #95

Closed gcusnieux closed 2 years ago

gcusnieux commented 2 years ago

Hi,

I update from 4.0.0 and I have some display problems with tables.

With 4.0.0

Capture d’écran 2021-12-21 à 08 52 39

With 5.1.0

Capture d’écran 2021-12-21 à 08 52 09

On github: https://github.com/gravitee-io/gravitee-policy-mock

Capture d’écran 2021-12-21 à 09 22 16

With the fix

Capture d’écran 2021-12-21 à 09 21 18
hyrious commented 2 years ago

GitHub doesn't apply whitespace: nowrap to table elements. Can you please look into it to see why your table gets short width?

gcusnieux commented 2 years ago

Yes, it's true. But I don't find why table content not break space

sindresorhus commented 2 years ago

Per the readme, the CSS is generated. You have to fix it at the source.

gcusnieux commented 2 years ago

Per the readme, the CSS is generated. You have to fix it at the source.

I don't understand how to fix the README @sindresorhus If with the same README the render is not the same on Github, it's a bug no ?

sindresorhus commented 2 years ago

@gcusnieux Read my comment again. I'm not saying the bug is invalid, I'm saying the fix is.

gcusnieux commented 2 years ago

No worries, when I read I understand that's fix should be provide by README. But I discovered generate-github-markdown-css now 😄