search

sindresorhus / globby

User-friendly glob matching
MIT License
2.53k stars 130 forks source link

gitignore patterns before globbing #123

Closed janat08 closed 4 years ago

janat08 commented 5 years ago

redo of #118. I had autoformatting (linting) on, and hadn't realized it until too late. Still fixes both #97, and xojs/xo#235 since I had to refractor warnings for api.

sindresorhus commented 5 years ago

There are merge conflicts and Still fixes both #97, and xojs/xo#235 since should still be separate PRs.

janat08 commented 5 years ago

it's done

janat08 commented 5 years ago

There're more conflicts, will you merge it this time?

janat08 commented 4 years ago

Please merge and reward

janat08 commented 4 years ago

@sindresorhus

janat08 commented 4 years ago

@sindresorhus

sindresorhus commented 4 years ago

This will need a lot of tests. And I think you should spend some more time on the implementation.

janat08 commented 4 years ago

Dont know, 80$, half a year late, isn't really enough for perfect implementation when fixing egregious code and perfect test coverage (from what I remember of your previous tests, I'm not sure what else is to be tested). If you reward me now, I can fix the conflicts, and run the tests again, so that I don't have to wait another half year. I actually specifically avoided your repos, because I accused you of bias, and then you compensated for that by demonstrating it.

janat08 commented 4 years ago

?

janat08 commented 4 years ago

?

janat08 commented 4 years ago

Okay I'll resolve the code change requests, and the merge conflicts once again, if that's all that's needed to merge and reward. People are actually switching from globby to underlying library because of this issue.

sindresorhus commented 4 years ago

Dont know, 80$

Issue bounties should not be considered as salary. They're meant as incentives for people to contribute.

half a year late

I have a lot of PRs to review and yours requires a lot of review.

I actually specifically avoided your repos, because I accused you of bias, and then you compensated for that by demonstrating it.

I have no idea what you're referring to, but I would indeed prefer it if you avoid my repos. I'd rather spend my time reviewing PRs where the submitter does a good job.

sindresorhus commented 4 years ago

I'm going to close this as it doesn't seem like you're going to resolve the inline comments or add tests like requested.