search

sindresorhus / globby

User-friendly glob matching
MIT License
2.51k stars 130 forks source link

Fix Windows compatibility for gitignore option #171

Closed barak007 closed 3 years ago

barak007 commented 3 years ago

Fixes #153

sindresorhus commented 3 years ago

This needs a test.

barak007 commented 3 years ago

Sorry for the description-less PR. I was in a harry and forgot to write a description. This should fix a case that ensureAbsolutePathForCwd received a cwd Windows path and a path to check which is also Windows path. It was clear that if you only apply slash to one of them it wont work.

The whole slashes approach is usually not that promising. but I couldn't change the entire codebase.