search

sindresorhus / globby

User-friendly glob matching
MIT License
2.51k stars 130 forks source link

globby's use of dir-glob.sync makes synchronous calls on its async call path #190

Closed DavidAnson closed 3 years ago

DavidAnson commented 3 years ago

Some scenarios may not permit/allow/support synchronous file system calls, so callers will use globby's asynchronous API. However, dir-glob.sync is called by that API and that calls pathType.isDirectorySync which calls fs.statSync, thereby compromising the user's scenario.

DavidAnson commented 3 years ago

Thanks!!