search

sindresorhus / globby

User-friendly glob matching
MIT License
2.51k stars 130 forks source link

Accept `URL` in function returned by `isGitIgnored` #207

Closed fisker closed 2 years ago

fisker commented 2 years ago

Fixes #202

I just realized this function also accept object with path, I guess it's easier to use in index.js, but as a public method, I don't think it should do such thing, anyway I didn't touch it.

sindresorhus commented 2 years ago

You need to update the readme too.

fisker commented 2 years ago

Ha, you already did.. but you missed one place. isGitIgnored section

fisker commented 2 years ago

The object with path property is also not mentioned there, we should remove support for it.

sindresorhus commented 2 years ago

Ha, you already did.. but you missed one place. isGitIgnored section

Fixed in main.

The object with path property is also not mentioned there, we should remove support for it.

👍