search

sindresorhus / globby

User-friendly glob matching
MIT License
2.51k stars 130 forks source link

Drop support for checking object with `path` property in function returns by `isGitIgnored` #208

Closed fisker closed 2 years ago

fisker commented 2 years ago

Ref: https://github.com/sindresorhus/globby/pull/207#issuecomment-1014263028

This behavior is never documented.

fisker commented 2 years ago

I found other bugs...

fisker commented 2 years ago

This one is ready, but I saw another bug here, the arrayUnion is not used correctly, when use fastGlob with objectMode, arrayUnion can't work, we should implement a function to unique the fastGlob result my path, I'll send another PR.

sindresorhus commented 2 years ago

Thanks for catching these bugs. I really appreciate it.