search

sindresorhus / globby

User-friendly glob matching
MIT License
2.49k stars 126 forks source link

Improve task expansion #219

Closed fisker closed 2 years ago

fisker commented 2 years ago

fast-glob accepts array as patterns, so we don't need flat tasks.

I'm not sure if this improves performance, but I don't think it will be slower.

In generateGlobTasks we can also avoid use multiple task, but I don't if worth to improve that part.

The benchmark test is broken, maybe I can tell if we fix that?

sindresorhus commented 2 years ago

And if it's slower, it should ideally be fixed in fast-glob, so it benefits everyone.

sindresorhus commented 2 years ago

The benchmark test is broken, maybe I can tell if we fix that?

Feel free to fix it, but simple benchmarks don't usually tell the full story. It only focuses on one specific performance case.