Closed fisker closed 2 years ago
@sindresorhus After second thought, this ignore
option for isGitIgnored
doesn't make sense to me either, why someone want to skip reading a specific .gitignore
file and let the result be true
?
Do you think we should remove it?
No idea. It was added a long time ago. I do agree with your reasoning though.
It was added in https://github.com/sindresorhus/globby/pull/48, I think it's added for xo
, maybe mean to check file is ignored by ignore
option, but it never works that way.
Yeah, let's remove it.
ignore
option inisGitIgnored()
mean to ignore.gitignore
files, but when runningglobby()
,ignore
mean to ignore matched files.For example:
This mean to glob all files that's not
gitignore
d, but except.gitignore
file, not mean don't read the.gitignore
file.Before:
After:
This is a little hard to test, I didn't add.