search

sindresorhus / globby

User-friendly glob matching
MIT License
2.49k stars 126 forks source link

Remove `ignore` option for `isGitIgnored` and `isGitIgnoredSync` #225

Closed fisker closed 2 years ago

fisker commented 2 years ago

Ref https://github.com/sindresorhus/globby/pull/223#issuecomment-1017255797

fisker commented 2 years ago

I still have one thing want to do before you can release, the expandDirectories requires file access, though I already reduced the tasks, we still expanding ignore repeatedly, we can expand them in 0~2 steps, one for the common ignore, one for the negative patterns.

fisker commented 2 years ago

I'm going to give up for this https://github.com/sindresorhus/globby/pull/225#issuecomment-1018440577.

I have tried, the logic became more complex, but didn't see much performance improvement, maybe because the file access is fast enough. Adding this logic also only benefit cases with multiple discontinuous negative patterns, it's not very common.

sindresorhus commented 2 years ago

Thanks for all the work you have been doing. I did a new release: https://github.com/sindresorhus/globby/releases/tag/v13.0.0