ignore is broken when it is not array (regression)

[alexander-akait]

Code:

import url from "url";
import path from "path";
import { globby } from "globby";

console.log(
  await globby("**/*", {
    followSymbolicLinks: true,
    ignore: "**/index.ejs",
    cwd: path.resolve(path.dirname(url.fileURLToPath(import.meta.url)), "public"),
    objectMode: true,
  }),
);

Output:

TypeError: directoryPaths.map is not a function

Can be fixed using ignore: ["**/index.ejs"], i.e. as array

[sindresorhus]

ignore is documented to accept an array, so you are using it incorrectly.

https://github.com/mrmlnc/fast-glob#ignore

[alexander-akait]

@sindresorhus It works correctly before, for example in v13, and fast-glob supports string and array of strings, but it was not documented, directoryPaths.map is not a function inside globby, because it can return string

[mrmlnc]

JFYI: https://github.com/mrmlnc/fast-glob/releases/tag/3.3.1

[sindresorhus]

but it was not documented

There are no guarantees when using undocumented behavior.

[sindresorhus]

I'm not a big fan of accepting both a string and string[] in general. It's better to make it simple and always do string[] when multiple values are accepted.

[sindresorhus]

I'm happy to accept a PR to improve the error message when a string is accidentally passed though.