RavenHursT
commented
2 years ago Looks like there's a beforeError hook..
https://github.com/sindresorhus/got/blob/4f24bd11fb50757ec8753a74e4a7b18de95ba155/source/core/index.ts#L1179-L1182
... but even then, you still only have access to error, which it looks like is just the HttpError in the aforementioned OP.
Maybe do a .bind(this) on the hook method somewhere so the consumer of this could at least reference this._request, or better yet, just change 1181 to something like this, so the user can have some kind of introspection on the request and response in question...
error = await hook(error, this._response)
szmarczak
What would you like to discuss?
I ran into a problem while using a library that's using
gotfor making server-side requests:https://github.com/MONEI/Shopify-api-node/issues/534
It appears that
got, if it receives a response w/ a non-2xx/3xx status code, that it just packages up a customHTTPErrorobject and throws it.The problem w/ that approach is that it doesn't seem like there's any way to get ahold of the response's body bytes (assuming there are any). It seems like all that's thrown are essentially the code and the message. Any
catchblock will not have any way to access the body of the response.In my case, the APIs being called, when errors are sent via 4xx responses, the body of those responses comes w/ very important data to help in debugging usage of the APIs in question.
Am I missing something? Is there some other way to get ahold of the body so that the stream can be read and parsed? ...
Checklist