search

sindresorhus / grunt-sass

Compile Sass to CSS
MIT License
1.01k stars 211 forks source link

Add --quiet option equivalent #273

Closed DaSchTour closed 7 years ago

DaSchTour commented 7 years ago

Add possibility to suppress warnings like described in SASS-Lang reference and like possible with grunt-contrib-sass

sindresorhus commented 7 years ago

Those are errors though, not warnings. I don't think it makes sense to ignore those.

DaSchTour commented 7 years ago

So in which place are the warning from @warn passed to grunt and where can I disable them?

sindresorhus commented 7 years ago

I don't know, sorry. Do some research.

DaSchTour commented 7 years ago

Well so it looks like this plugin treats warnings as errors and so doesn't follow the SASS specification of how to treat @warn https://www.sass-lang.com/documentation/file.SASS_REFERENCE.html#_6

xzyfer commented 7 years ago

@error are errors and @warn are warning. If I'm understanding correctly you wish to replicated the --quiet flag that both node-sass and ruby-sass provide via their CLIs. In that case this patch is incorrect.

What you should be doing is passing a quiet option to the node-sass render call. However node-sass does not currently support the quiet option. You should open an issue with node-sass to enable quiet to be passed to render/renderSync.

DaSchTour commented 7 years ago

@xzyfer okay, that's even worser than I ever could imagine :see_no_evil: