search

sindresorhus / grunt-sass

Compile Sass to CSS
MIT License
1.01k stars 211 forks source link

Update node-sass dependency to version compliant with nodejs. Yes, I read Readme. #277

Closed halfnibble closed 6 years ago

halfnibble commented 6 years ago

Yes, I read the Readme and the article on semver. I understand this pull request should not be necessary, in theory.

However, in practice, on a clean Docker VM with a fresh nodejs and a brand new install of grunt-sass, I do not get a compatible version of node-sass. I realize that semver dictates the latest minor version should be installed, but this consistently does not happen. And I have no idea why.

halfnibble commented 6 years ago

Ok. I figured out the reason semver wasn't working for me. No surprise, it was developer error. My Docker build was mistakenly set to copy over the node_modules folder from my local machine. It contained an older, incompatible version of node-sass.

But why not update the node-sass dependency anyway? Every time a developer updates his or her node, they are going to run into issues like this. We could potentially save hundreds of developers thousands of debugging hours by forcing a newer version of node-sass that is both fully backwards compatible and full of critical bug fixes.

sindresorhus commented 6 years ago

Every time a developer updates his or her node, they are going to run into issues like this.

If that was true there would be more issues about this.

We could potentially save hundreds of developers thousands of debugging hours by forcing a newer version of node-sass that is both fully backwards compatible and full of critical bug fixes.

You make it sound like there are no downsides. Bumping to latest means it's impossible for people to force an older v4 version of node-sass and have it deduplicated so grunt-sass will use it too. I've actually had people complain about this before. Everything is simple when you look at it from just one side.