search

sindresorhus / grunt-shell

Run shell commands
MIT License
949 stars 126 forks source link

Turn `stdout`, `stderr` and `failOnError` to true by default #39

Closed sindresorhus closed 10 years ago

sindresorhus commented 11 years ago

Which is basically the opposite of what it currently is. After using this for a while I feel like it's the more common and expected behavior.

Won't bother until grunt 0.5 which will require changes anyway.

bevacqua commented 11 years ago

@sindresorhus could you merge this in, bump version, and npm publish? :octocat:

alopatin commented 11 years ago

+1 Was surprised this wasn't the default behavior today.

jbdeboer commented 11 years ago

Please merge this defaults. I was burned by "failOnError" defaulting to false today.

blakeembrey commented 11 years ago

+1 already!

henryruhs commented 10 years ago

Me too on Travis CI... please set "failOnError" to true...

cburgmer commented 10 years ago

I implemented my test runner using grunt-shell and never got notified that my tests failed. Please change this.

sindresorhus commented 10 years ago

Won't bother until grunt 0.5 which will require changes anyway.

This would be a breaking change and I'm not going to do that yet. If you would have read the docs it clearly states the fact that these are false by default. The reason is that when this task was created a lot of people complained that grunt tasks was too noisy. I guess you can't please everyone.

henryruhs commented 10 years ago

Disagree, you should always follow the expected behaviour of the scripts that are running.

AnthonyAkentiev commented 10 years ago

+1. I need that too

STRd6 commented 10 years ago

Woohoo!