search

sindresorhus / gulp-changed

Only pass through changed files
MIT License
742 stars 44 forks source link

Promisify `fs` methods #62

Closed adamkiss closed 7 years ago

adamkiss commented 7 years ago

I want to reuse this plugin elsewhere, so in the spirit of Open Source I took a crack at one of the 'help wanted' issues to familiarize myself with the codebase.

Please let me know your thoughts. Should close #59.

adamkiss commented 7 years ago

Bump @sindresorhus ?

sindresorhus commented 7 years ago

Thanks for working on this :)

adamkiss commented 7 years ago

No problem, thanks for making it in the first place :)

sindresorhus commented 7 years ago

Last thing that I forgot earlier. You need to update the hasChanged documentation, to remove callback and mention that it needs to return a Promise.

adamkiss commented 7 years ago

@sindresorhus Yeah, I wasn't sure what's the accepted/usual open source way of doing changes in docs, and other non-code things. Should I go ahead and change the docs, and you'll do the rest afterwards?

edited to sound less like I just woke up

sindresorhus commented 7 years ago

Shall I go ahead and change the docs, and the rest (like up version in package, …) will you do?

Only the docs. I'll do the up version when publishing a new version.

adamkiss commented 7 years ago

@sindresorhus sorry, had a busy few days. Updated the readme.

sindresorhus commented 7 years ago

Thank you @adamkiss. I really appreciate this contribution :)