buffering all files and the `.end()` event could easily cause excessive memory use

[robrich]

This also seems to break the "plugin should do one thing" rule.

cc: @contra, @phated

[phated]

@robrich can you explain this better?

[robrich]

Perhaps "leak" is not the best term. Perhaps better said "excessive memory use."

A plugin should take an input file, do something, and return a result. Collecting all files and doing something at the end is really bad form. The only good use-case I can see is concat(), but even then, use require such that you don't need to.

[yocontra]

@robrich for plugins that need to operate on all files (mocha, concat, etc.) this is fine

[phated]

I think this is fine. Am I correct in my assumption that through2 is just causing artificial backpressure in this instance?