sindresorhus / gulp-filter

Filter files in a `vinyl` stream
MIT License
315 stars 37 forks source link

Matching problem on Windows #52

Closed kparkov closed 8 years ago

kparkov commented 9 years ago

Some filters are not working on Windows.

This works:

var scssfilter = filter(["**/*.scss"], { restore: true });

But this does not (everything is filtered out):

var scssfilter = filter(["Components/**/*.scss"], { restore: true });

It seems anything more advanced is not working. This does not work either:

var scssfilter = filter(["*", "!**/*.scss"], { restore: true });

It works with other libs utilizing minimatch, such as gulp.src.

kparkov commented 9 years ago

I should add that I am not aware whether this is a Windows-exclusive problem. It's just the platform I encountered the error on.

notpeelz commented 9 years ago

I'm experiencing the same problem here, albeit under a Linux environment. This is definitely not a Windows-exclusive issue and should be renamed accordingly.

notpeelz commented 9 years ago

@kparkov, see my issue report; you most likely forgot to set the base directory.

kparkov commented 8 years ago

@LouisTakePILLz, I agree, setting the base directory seems to solve the problem. I am closing this issue.