Closed duncanbeevers closed 10 years ago
@mariocasciaro @adam-lynch any thoughts on this?
Why don't just expose it as an option?
Yeah, could probably just expose the minimatch options. Though, should matchBase be on by default? I know I want dot
to be.
I think it's more intuitive for the user if we just keep minimatch default behavior, which is well known, instead of documenting what are the options enabled by default in gulp-filter. I vote for having matchBase disabled by default as it is in minimatch.
@mariocasciaro agreed
Okie dokie.
@duncanbeevers would you like to implement the change? Just do the change and force push to this remote branch to update the PR ;)
I'd be happy. Let me see if I can carve out some time today or tomorrow while traveling to knock it out.
It looks like the current implementation uses the non-default option dot: true
. Do you want to preserve this behavior or make the options perfectly symmetrical?
I left it as simple as possible, threading options through to multimatch. This is a potentially-breaking change to some builds.
@duncanbeevers mind adding a short note about people having to use dot: true
for it to accept files with leading dot
?
Updated tests.
Added options description to Readme.
Added explicit note about dot: true
behavior.
Looking good. Thanks :)
I'm using
gulp-bower-files
to get access to all my vendored assets. I'd like to partition them by file type.I propose this
rather than