search

sindresorhus / gulp-filter

Filter files in a `vinyl` stream
MIT License
315 stars 37 forks source link

Matching parent paths #74

Closed stefanKuijers closed 7 years ago

stefanKuijers commented 7 years ago

Thanks for the handy plugin.

I ran into the following problem while running my gulp task for a different directory than my workin directory:

filter: '**/*.js' did not match: ..\..\path\to\script.js

To me this really seems to unexpected behavior. I am aware of this issue.

My question is: is there any chance to merge in the snippet @cb1kenobi posted? It would be great if I don't have to fork and publish my own package for this.

Thanks in advance

nfroidure commented 7 years ago

I do no see any PR for that, has it been closed?

stefanKuijers commented 7 years ago

Sadly I don't really have time currently to create a PR that's why I just added a link to the code which solves it.

First I would like to know or there is any interest. If there is interest I will see when I can make time to create a PR

cb1kenobi commented 7 years ago

@nfroidure @stefanKuijers PR submitted!

stefanKuijers commented 7 years ago

@cb1kenobi Awesome!

stefanKuijers commented 7 years ago

@sindresorhus : Thanks!