search

sindresorhus / gulp-nunjucks

Precompile Nunjucks templates
MIT License
152 stars 20 forks source link

Undefined value of template function argument #9

Closed mariuszdev closed 8 years ago

mariuszdev commented 8 years ago

Hello,

I've decided to report this issue here, not in nunjucks repository, mainly because the problem occured after I've upgraded gulp-nunjucks to 2.1.1, regardless of the version of nunjucks.

As the title says, when I'm invoking function with argument within template, the value of the argument is undefined. It works when I'm using gulp-nunjucks@1.0.3. I haven't tried anything between these two versions.

My first thought was to try switch nunjucks version, unfortunately with no effect. Only downgrading gulp-nunjucks version helped.

sindresorhus commented 8 years ago

Other than the Nunjucks bump, the only real changes since 1.0.3 were https://github.com/sindresorhus/gulp-nunjucks/commit/8e054d48ea4a4b046ae86438d4c1de27bfae6095 (by @d10) and https://github.com/sindresorhus/gulp-nunjucks/commit/dcd750ad7bef52fa0b2cd6c3f16ef732dab0846e (by @renanvaz). Can you provide something that reproduces the issue?

renanvaz commented 8 years ago

@sindresorhus I have changed only one line of code in my commit (in compile method). @pilaas It is a error of compile or precompile?

bnjmnt4n commented 8 years ago

Not too sure what you mean @pilaas :cry: could you provide some simple code that fails?

mariuszdev commented 8 years ago

@renanvaz Precompile. I'll soon paste here some example code. "Hope" it will also fail.

mariuszdev commented 8 years ago

My bad. I haven't upgraded browser nunjucks and it seems it wasn't working with an output of upgraded gulp-nunjuck. Sorry for the confusion.