search

sindresorhus / gulp-vulcanize

Concatenate a set of Web Components into one file
MIT License
100 stars 25 forks source link

Support buffer mode of vulcanize #10

Closed ragingwind closed 10 years ago

ragingwind commented 10 years ago

https://github.com/sindresorhus/gulp-vulcanize/issues/1#issuecomment-60884605

ragingwind commented 10 years ago

fixed as follow your point, but vulcanize 0.5.0 has some issue with eof flag https://github.com/Polymer/vulcanize/pull/84

sindresorhus commented 10 years ago

@ragingwind can you update your PR for Vulcanize 0.6.0? (to adapt to your fix)

ragingwind commented 10 years ago

There is no update of vulcanize's api interface. we would need to update vulcanize version in package.json. @ebidel already has been send PR for versioning and version has been updated before this PR. So I think It is better to make a new PR to have clean history

sindresorhus commented 10 years ago

Ok, cool. I just thought you changed some behaviour with the eof thing.