search

sindresorhus / gulp-vulcanize

Concatenate a set of Web Components into one file
MIT License
100 stars 25 forks source link

Fix for output paths should be relative #18

Closed k2wanko closed 9 years ago

k2wanko commented 9 years ago

I think Issue #12 is not yet complete.

I have a fix.

Please check.

k2wanko commented 9 years ago

@sindresorhus Fixed.

I used the file.cwd. It does not work in file.base

kevva commented 9 years ago

Hm, why didn't it work?

k2wanko commented 9 years ago

@kevva

Did not work if HTML is relative path.

So I was further modified code.

To be the output to full path. (https://github.com/sindresorhus/gulp-vulcanize/pull/18/files#diff-168726dbe96b3ce427e7fedce31bb0bcR27)

sindresorhus commented 9 years ago

Merge conflict needs to be fixed and better reasoning provided for why this is needed.

sindresorhus commented 9 years ago

Closing for lack of response.