Remove gulp peer dependency?

sindresorhus / gulp-zip

ZIP compress files

MIT License

270 stars 47 forks source link

Remove gulp peer dependency? #114

Closed spalger closed 5 years ago

spalger commented 5 years ago

We're using gulp-zip directly with vinyl-fs (without gulp) and would like to remove the warning when installing dependencies caused by the listed gulp peer dependency. It seems this library doesn't actually have a dependency on gulp, and seems like maybe we could just remove it. Thoughts?

sindresorhus commented 5 years ago

It's using peerDependencies to indicate that it won't work with Gulp 3. How about I make it optional using peerDependenciesMeta?

https://github.com/yarnpkg/rfcs/blob/master/accepted/0000-optional-peer-dependencies.md (It's implemented in Yarn and npm)

spalger commented 5 years ago

Sounds good to me!

spalger commented 5 years ago

PR incoming