search

sindresorhus / hide-files-on-github

Chrome extension - Hide nonessential files from the GitHub file browser
https://chrome.google.com/webstore/detail/hide-files-on-github/lpnakhpaodhdkleejaehlapdhbgjbddp
MIT License
320 stars 36 forks source link

Fix button alignment - fixes #25 #27

Closed clayreimann closed 8 years ago

clayreimann commented 8 years ago

I wish you could git push --force with the Github GUI :cry:

sindresorhus commented 8 years ago

with the Github GUI

Please don't use the GitHub UI for actual code changes.

clayreimann commented 8 years ago

with the Github GUI

Please don't use the GitHub UI for actual code changes.

I meant the desktop client, in any case I fixed the git remote to use ssh. push --force enabled!

radiovisual commented 8 years ago

I have confirmed that this PR does what it claims to do, and it works, so it's safe for a merge, however, I just wanted to point out that I think I the "New Pull Request" doesn't need to be changed. There is plenty of room for the "New Pull Request" button to fit on the existing UI without modifying it. This PR makes the button smaller, and changes the text to "New PR". If you compare the unchanged button with the changed button, my vote is with the button being unchanged:

before-after

These images above are screenshots from my browser, where I pulled in @clayreimann's working branch, so I know that the button has enough room to fit and still work as expected.

sindresorhus commented 8 years ago

Thanks @clayreimann :) Sorry about the delay in merging.

sindresorhus commented 8 years ago

@radiovisual That doesn't work when the branch is not named master:

screen shot 2016-03-15 at 17 24 05
radiovisual commented 8 years ago

Ok, now I see. Thanks.