sindresorhus / hide-files-on-github

Chrome extension - Hide nonessential files from the GitHub file browser
https://chrome.google.com/webstore/detail/hide-files-on-github/lpnakhpaodhdkleejaehlapdhbgjbddp
MIT License
320 stars 35 forks source link

Don't make me choose between dimming and hiding. #38

Closed jamestalmage closed 8 years ago

jamestalmage commented 8 years ago

I liked the dimmed look, but, now I have to choose between dimming and hiding.

Instead of the "dimmed" / "hidden" choice. I think there should be two checkboxes.

If you select both, they default to hidden, but when you expand with the button they show up dimmed.

If you unselect both, the extension is essentially disabled (Sort of pointless if someone chooses that, but whatever).

If you only check one or the other, you git similar behavior to what we have now (dimmed but not hideable with no button, or hideable but not dimmed).

sindresorhus commented 8 years ago

I think they should just be dimmed when expanded in hidden mode. I've often had to look twice to find the dotfiles when I click Show dotfiles. Having them dimmed makes it clear where they are. Thoughts?

jamestalmage commented 8 years ago

👍 That's what I would pick if given the option, so I'm fine with it being automatic.

jamestalmage commented 8 years ago

So...

  1. Always dim.
  2. Options are reduced to a hide / don't hid checkbox and the regex.

Next Question,

Should the hide/show button always be there? Regardless of whether or not they've checked 2? Meaning, they can always hide, but we just give them a choice as to what the default state is?

radiovisual commented 8 years ago

So...

  1. Always dim.
  2. Options are reduced to a hide / don't hid checkbox and the regex.

👍

I like the idea of always dim, since this extension is all about hiding the dotfiles, it should also make it easy for you to identify them when shown.

@jamestalmage , I am not sure I understand the question:

Should the hide/show button always be there? Regardless of whether or not they've checked 2? Meaning, they can always hide, but we just give them a choice as to what the default state is?

Can you explain? Do you mean you have specific criteria for when the toggle button should not be visible?

sindresorhus commented 8 years ago

Fixed by #40.