search

sindresorhus / hide-files-on-github

Chrome extension - Hide nonessential files from the GitHub file browser
https://chrome.google.com/webstore/detail/hide-files-on-github/lpnakhpaodhdkleejaehlapdhbgjbddp
MIT License
320 stars 36 forks source link

Restore dim-only option #41

Closed fregante closed 8 years ago

fregante commented 8 years ago

I was using the dim-only option and it was perfect, I'm not sure of why it was removed in #40 :(

Since the extension is flexible enough to allow the hiding of any files, it's a great way to just bring focus to the important files, rather than completely hiding files that still affect the project, like travis.yml

radiovisual commented 8 years ago

Yeah, I never used the dimming function but the other day I ran into a situation where it would have been nice to have (I think I was trying to locate/compare a few configuration files in two different but similar repos) and it made me think that the old dimming feature would have come in handy. So I guess I vote to restore the dimming feature as well.

fregante commented 8 years ago

As an additional reason to keep files dimmed instead of hiding them is the jumping caused by hiding them. Trying to click on something that changes position is infinitely more annoying than .travis.yml files. Let me know whether I should make a PR to restore the behavior or simply publish dim-files-on-github on Chrome Web Store

radiovisual commented 8 years ago

@bfred-it , I think you should go for the PR. I have had more use cases in these last few days where I would have liked to see this option restored. If you need some pointers, you can reference the code that was originally used to add the dim-option in commit: https://github.com/sindresorhus/hide-files-on-github/commit/fae9328aa92ed71141f4ae1577e7771dd79dcceb. Though, it won't be a 1:1 translation, since some refactors have happened since then, so if you use the old code as reference, then please reference the new code as well.

Alternatively, for anyone who wants the dimming functionality back right away, they have the option of manually installing version 1.4.1, then watch this repo for updates.

As far as the "jumping" goes, there will always be a little "jumping" because we are messing with the DOM after it has loaded. PR #42 groups the files at the top of the list, and I find that the "jump" is much better contained with that new feature.

fregante commented 8 years ago

I saw that. I'll avoid the PR because stuff would still be moving around so it wouldn't solve much

taylorjosephgriffin commented 4 years ago

so are you not able to straight up hide files anymore? because they are only dimming for me.

taylorjosephgriffin commented 4 years ago

okay its hiding them but only after i refresh

fregante commented 4 years ago

You’re encountering https://github.com/sindresorhus/hide-files-on-github/issues/87 and #92

Chrome doesn’t have the latest version yet