search

sindresorhus / hide-files-on-github

Chrome extension - Hide nonessential files from the GitHub file browser
https://chrome.google.com/webstore/detail/hide-files-on-github/lpnakhpaodhdkleejaehlapdhbgjbddp
MIT License
320 stars 36 forks source link

Group dotfiles at the top of the list. (#39) #42

Closed champagst closed 8 years ago

radiovisual commented 8 years ago

Looking good! Nice work! I just tested your PR and everything seems to work the way it should, only just one thing: all of the files that are mentioned in the user-defined regular expression should also be grouped at the top, since that regular expression marks the files that users want to hide (some of which, aren't necessarily dotfiles, like the license file). You have grouped all the dotfiles at the top, but the license file (from the default RegExp: ^\.|^license|^appveyor\.yml$) is not being grouped with the others:

image

champagst commented 8 years ago

That definitely makes more sense. I was looking at how the dot files were grouped at the top in a linux listing, but this allows more files to be hidden.

radiovisual commented 8 years ago

Awesome. Just tested it. Works great! Let's see if @sindresorhus and @jamestalmage agree.

radiovisual commented 8 years ago

@sindresorhus , I have been using this PR's version of the extension for the last 5 days. It works great! I would say it is ready to be merged.

jamestalmage commented 8 years ago

I have not tested it, but the code looks good to me. Since you've already been beta testing for 5 days, I'd say merge and ship it!

sindresorhus commented 8 years ago

Thanks @champagst :)

Published now. Should be updated in your Chrome's within an hour.