search

sindresorhus / hide-files-on-github

Chrome extension - Hide nonessential files from the GitHub file browser
https://chrome.google.com/webstore/detail/hide-files-on-github/lpnakhpaodhdkleejaehlapdhbgjbddp
MIT License
320 stars 35 forks source link

Let's add package-lock.json to nonessentials list! #52

Closed revelt closed 7 years ago

revelt commented 7 years ago

Hi all! Should we add package-lock.json among nonessentials? It's kindof meaningless when browsing GitHub page, isn't it?

radiovisual commented 7 years ago

Seems it is already on the list: https://github.com/sindresorhus/hide-files-on-github/blob/master/extension/api.js#L15, but it doesnt show up a default when the extension is loaded.

revelt commented 7 years ago

nah,

not_being_hidden

is it working at yours? I can see it's not hidden on your eth-price too for example..

radiovisual commented 7 years ago

Yeah, you are right. It's not working. It IS added to the defaults in api.js, but when I inspect the contents of the 1.7.0 release archive, the package-lock.json entry is not there. This just means that this line of code has not made it to the published version of the extension yet.

radiovisual commented 7 years ago

I have confirmed that package-lock.json files are hidden when you use the source code from this repository as an extension, so I think this issue can be closed after a new version is published to the Chrome Web Store.

So as a workaround for now, you could clone the repo and install the extension manually to get this feature while you wait for the new version to be published.

sindresorhus commented 7 years ago

New release is out.