search

sindresorhus / hide-files-on-github

Chrome extension - Hide nonessential files from the GitHub file browser
https://chrome.google.com/webstore/detail/hide-files-on-github/lpnakhpaodhdkleejaehlapdhbgjbddp
MIT License
320 stars 35 forks source link

Support non-root listings #55

Closed fregante closed 7 years ago

fregante commented 7 years ago

As mentioned by a review: https://chrome.google.com/webstore/detail/hide-files-on-github/lpnakhpaodhdkleejaehlapdhbgjbddp/reviews

Only work for files at root directory

e.g. https://github.com/babel/babel/tree/7.0/packages/babel-cli

sindresorhus commented 7 years ago

Not something I would ever need, but happy to take a pull request if anyone wants it.

radiovisual commented 7 years ago

I think this makes sense for larger repos. I have run into this a few times. You get used to the way this extension works, so it throws you off when you visit a larger repo with "non-essential" files outside of the root, and it gives the impression that the extension is broken.

I think I looked into this feature a while back, but there was something preventing me from getting it to work properly, can't remember what it is now, but I think was either that GitHub markup was in flux, or the non-root tables weren't specific enough to detect, something along those lines, whatever it was, it was messing with our detections, but maybe we won't have any of those problems if we try again.