sindresorhus / hide-files-on-github

Chrome extension - Hide nonessential files from the GitHub file browser
https://chrome.google.com/webstore/detail/hide-files-on-github/lpnakhpaodhdkleejaehlapdhbgjbddp
MIT License
320 stars 36 forks source link

Show clickable names of hidden files #60

Closed fregante closed 7 years ago

fregante commented 7 years ago

Closes #57

Based on #59 (ignore DRY commit), only look at https://github.com/sindresorhus/hide-files-on-github/pull/60/commits/11f09252038302c4a08462a0832e4f3d3aacb436 for the links and https://github.com/sindresorhus/hide-files-on-github/pull/60/commits/76d2c7b88d8295e1643e77328e8b67231cf76a8b for the chevron.

demo

fregante commented 7 years ago
fregante commented 7 years ago

If Show nonessentials can appear below .. in non-root listings instead of above .. as defined by #59 then this PR can be CSS only 👍

Edit: actually <table> won't let me do this.

radiovisual commented 7 years ago

So I may have given this feature a hard time at first, but now I like it. :rofl:

Does it interfere/override or work in tandem with the RegExp in the options?

fregante commented 7 years ago

👍 works in tandem, it shows the links it hides.

sindresorhus commented 7 years ago

I have to admit this is a really good POC ✨

This feature is still not something I would use, but I'm ok with adding it as an option.

sindresorhus commented 7 years ago

In https://github.com/babel/babel, the ... are too close to the edge:

screen shot 2017-07-15 at 19 49 11
fregante commented 7 years ago

Also something to tackle when I have time to fix this: sub-folder links like

screen shot 2017-07-18 at 02 00 10

As seen on https://github.com/mozilla/web-ext

fregante commented 7 years ago

Fixed both issues 👍

sub folders color padding right
fregante commented 7 years ago

I felt that f50f5fe was needed to improve wrapping of long lists (i.e. avoid ellipsis mid-link)

Here's a couple of before and after. The etc... is a link that matches the chevron exactly, it opens the full list.

babel

before after

web-ext

before after
sindresorhus commented 7 years ago

The files are showing as blue links for me now, which is IMHO too noisy.

sindresorhus commented 7 years ago

This feature is still not something I would use, but I'm ok with adding it as an option.

@bfred-it What are your thoughts on? :arrow_up:

fregante commented 7 years ago

Blue links were a mistake, will fix now, it's definitely ugly that way.

I can add it as an option, 👍 but:

  1. What do you think about making it enabled by default? This way new users can find it useful and old users will be able to revert it.

  2. What's the toggle button's label if they disable this option? Chevron or text?

sindresorhus commented 7 years ago
  1. Sure.
  2. Text, like it is now, I would say.
fregante commented 7 years ago

Make it an option looks like

screen shot 2017-07-20 at 16 37 16
fregante commented 7 years ago

Add visual example to options looks like

screen shot 2017-07-21 at 14 41 45
sindresorhus commented 7 years ago

Really nice touch on the settings look ❤️

sindresorhus commented 7 years ago

Can you update the text in the readme In the options, you can choose what files/directories to hide with a custom regex. with something that describes the two styles.

fregante commented 7 years ago
screenshot of the readme
sindresorhus commented 7 years ago

Amazing stuff ✨