Closed fregante closed 7 years ago
So I may have given this feature a hard time at first, but now I like it. :rofl:
Does it interfere/override or work in tandem with the RegExp in the options?
👍 works in tandem, it shows the links it hides.
I have to admit this is a really good POC ✨
This feature is still not something I would use, but I'm ok with adding it as an option.
In https://github.com/babel/babel, the ...
are too close to the edge:
Also something to tackle when I have time to fix this: sub-folder links like
As seen on https://github.com/mozilla/web-ext
Fixed both issues 👍
I felt that f50f5fe was needed to improve wrapping of long lists (i.e. avoid ellipsis mid-link)
Here's a couple of before and after. The etc...
is a link that matches the chevron exactly, it opens the full list.
The files are showing as blue links for me now, which is IMHO too noisy.
This feature is still not something I would use, but I'm ok with adding it as an option.
@bfred-it What are your thoughts on? :arrow_up:
Blue links were a mistake, will fix now, it's definitely ugly that way.
I can add it as an option, 👍 but:
What do you think about making it enabled by default? This way new users can find it useful and old users will be able to revert it.
What's the toggle button's label if they disable this option? Chevron or text?
Make it an option
looks like
Add visual example to options
looks like
Really nice touch on the settings look ❤️
Can you update the text in the readme In the options, you can choose what files/directories to hide with a custom regex.
with something that describes the two styles.
Amazing stuff ✨
Closes #57
Based on #59 (ignore DRY commit), only look at https://github.com/sindresorhus/hide-files-on-github/pull/60/commits/11f09252038302c4a08462a0832e4f3d3aacb436 for the links and https://github.com/sindresorhus/hide-files-on-github/pull/60/commits/76d2c7b88d8295e1643e77328e8b67231cf76a8b for the chevron.