sindresorhus / hide-files-on-github

Chrome extension - Hide nonessential files from the GitHub file browser
https://chrome.google.com/webstore/detail/hide-files-on-github/lpnakhpaodhdkleejaehlapdhbgjbddp
MIT License
320 stars 36 forks source link

Readable regexes in options + validation #61

Closed fregante closed 7 years ago

fregante commented 7 years ago

Changes

Before and After

before after
fregante commented 7 years ago

Validation 😎

validation

fregante commented 7 years ago

Is webext-options-sync worth adding? https://github.com/bfred-it/webext-options-sync/blob/master/webext-options-sync.js

Not particularly needed but I think it would replace 3/4 functions in api.js and options.js. I feel like I'm reimplementing it inline :D

sindresorhus commented 7 years ago

Yes, go ahead and add it :)

sindresorhus commented 7 years ago

Looks very good. Much better UX now ❤️

fregante commented 7 years ago

It doesn't look like using webext-options-sync is possible as is, since it doesn't support:

fregante commented 7 years ago

This is good to merge. The other I think is missing the option (which depends on this)

sindresorhus commented 7 years ago

Awesome! 👌