Improve TypeScript definition, refactor definition to CommonJS compatible export

sindresorhus / hook-std

Hook and modify stdout and stderr

MIT License

54 stars 12 forks source link

Improve TypeScript definition, refactor definition to CommonJS compatible export #21

Closed BendingBender closed 5 years ago

BendingBender commented 5 years ago

Breaking change:

improve definition, take into account that transform function must return different types depending on silent mode
refactor definition to CommonJS compatible export

~~Waiting for https://github.com/SamVerschueren/tsd/pull/22.~~

BendingBender commented 5 years ago

@sindresorhus Currently, we allow returning null or undefined from the *Transform functions. JS-wise it doesn't make a difference whether we return null or undefined or even a number. My changes are already breaking, should we limit this to just undefined for the sake of consistency?

sindresorhus commented 5 years ago

My changes are already breaking, should we limit this to just undefined for the sake of consistency?

👍