Closed ronami closed 5 years ago
Thanks for creating a TypeScript definition. 🙌 Can you follow this styleguide?
Some examples:
Hey, I updated the PR by documenting the types in index.d.ts
.
Just pointing out some things in the PR:
any
over unknown
to match Node's definition: https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/node/globals.d.ts#L192.README.md
which uses 2 separate files. I wasn't sure how to document it so I used two sets of ```s.I went over the styleguide and didn't find anything that's missing, is there anything specific I should fix?
Thanks!
I used any over unknown to match Node's definition: DefinitelyTyped/DefinitelyTyped:types/node/globals.d.ts@master#L192 .
The Node.js type definitions are not very good nor strict.
Looks good. Thanks :)
Summary
Hey, pretty straight-forward: Adding some TypeScript definitions.