The problem was that I was using findUp.sync to detect whether the local node_modules is a parent directory of globalDir. I expected that function to only return true when the path in the first argument was found while traversing up the directory tree, but because we provide an absolute path, it actually always returned true.
This wasn't caught in CI because there's no test where we invoke a global CLI, but want to resolve to a version in the local node_modules, so I've added a regression test.
@sindresorhus @novemberborn: In addition to these tests, I've verified that the "prefers local version of ava" test passes in ava when linked to this branch.
sindresorhus
commented
5 years ago
This fixes the issue described in avajs/ava#2168.
The problem was that I was using
findUp.syncto detect whether the localnode_modulesis a parent directory ofglobalDir. I expected that function to only return true when the path in the first argument was found while traversing up the directory tree, but because we provide an absolute path, it actually always returned true.This wasn't caught in CI because there's no test where we invoke a global CLI, but want to resolve to a version in the local node_modules, so I've added a regression test.
@sindresorhus @novemberborn: In addition to these tests, I've verified that the "prefers local version of ava" test passes in ava when linked to this branch.