search

sindresorhus / is-reachable

Check if servers are reachable
MIT License
380 stars 40 forks source link

Browser version needs improvement #13

Open silverwind opened 7 years ago

silverwind commented 7 years ago

favicon.ico is unreliable on modern sites that use SVG or PNG favicons, which could also be inlined as a datauri. I think we need to get creative and find better methods. Maybe a <script> tag could be of use because it's inherently cross-origin compatible.

sindresorhus commented 7 years ago

It's only unreliable when you don't know the site it's going to be used one. Favicon serves the purpose of is-online fine as we have a hardcoded list of hosts, but since this module accepts user specified hosts, I guess this makes sense. Or we could just document that the hosts needs to have a /favicon.ico.

detj commented 3 years ago

@sindresorhus should also document that the timeout option will not work in browsers. #50

detj commented 3 years ago

@sindresorhus should also document that the timeout option will not work in browsers. #50

landed in https://github.com/sindresorhus/is-reachable/commit/4dd216ccf6bbc26e07c29208a02737cd9088aadb