search

sindresorhus / is

Type check values
MIT License
1.68k stars 109 forks source link

Add `is.propertyKey` #138

Closed PopGoesTheWza closed 3 years ago

PopGoesTheWza commented 3 years ago

Fixes #136

PopGoesTheWza commented 3 years ago

@sindresorhus older version of Typescript may not include Symbol in the PropertyKey definition. Would that be an issue?

sindresorhus commented 3 years ago

You need to add it to the readme.

PopGoesTheWza commented 3 years ago

Never knew PropertyKey was a built-in type, always used keyof any instead.

Ouch! I used string | number before venturing in the Typescript standard libraries (which is full of good information). Support for symbol keys was added recently to Typescript.

gioragutt commented 3 years ago

@PopGoesTheWza thanks for your contribution bro 🤘🏻

PopGoesTheWza commented 3 years ago

thanks for your contribution bro

On a totally irrelevant and lighthearted matter, I viscerally hate the term "bro". I can do with "dude" or "mate" though... ;)

gioragutt commented 3 years ago

@PopGoesTheWza I swear I thought about it ASA I posted the comment 😅 Thanks for pointing it out 🙏🏻