search

sindresorhus / is

Type check values
MIT License
1.68k stars 109 forks source link

Add `.isWeakRef()` #164

Closed bigbigDreamer closed 2 years ago

bigbigDreamer commented 2 years ago

Changes as follow, Support #143 :

  1. Support ts complier for WeakRef: update typescript to v 4.6.2(latest)
  2. Support test mock with JSDOM: update jsdom to v 19.0.0(latest)
  3. Fix lint error: #163
  4. Add complierOptions for tsconfig.xo.json: fix follow error, However, the ide still reports an error. I don't quite clear which tsconfig the test file is ultimately controlled by. It seems that the addition is invalid.
    • image
bigbigDreamer commented 2 years ago
image

All tests can passed in my local env.I don't know why ci doesn't pass. @sindresorhus

bigbigDreamer commented 2 years ago

Sorry, I may have used --rebase upstream, so my commits are so ugly.

sindresorhus commented 2 years ago

You should always make a separate branch for each pull request.

bigbigDreamer commented 2 years ago

You should always make a separate branch for each pull request.

Ok, when I get home later and reopen a branch, I just arrived at the company now, ready to work.