search

sindresorhus / is

Type check values
MIT License
1.68k stars 109 forks source link

Support BigInt detection #39

Closed sindresorhus closed 5 years ago

sindresorhus commented 6 years ago

Issuehunt badges

http://2ality.com/2017/03/es-integer.html https://groups.google.com/forum/#!msg/v8-dev/x571Gr0khNo/y8Jk0_vSBAAJ

Also BigInt64Array and BigUint64Array

Blocked by https://github.com/Microsoft/TypeScript/issues/15096

vladfrangu earned $40.00 by resolving this issue!

sunilhari commented 6 years ago

@sindresorhus Is it time already for this ??

https://twitter.com/v8js/status/991705626391732224

transitive-bullshit commented 6 years ago

It'll be a long while still before these v8 changes land in Node. See this node release list which details the supported versions of v8.

Hoishin commented 6 years ago

Node already supports BigInt behind flag. screen shot 2018-05-22 at 12 14 29

Hoishin commented 6 years ago

Since this library is written in TypeScript, we probably have to wait for TypeScript to support BigInt, BigInt64Array, and BigUint64Array. An issue is opened for this: https://github.com/Microsoft/TypeScript/issues/15096 And it is listed in TypeScript 3.0 milestone: https://github.com/Microsoft/TypeScript/milestone/70 It seems they started working on the milestone 2 weeks ago but only 2% are closed. It will still take time.

sindresorhus commented 5 years ago

TypeScript now supports BigInt: https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-2.html

IssueHuntBot commented 5 years ago

@issuehunt has funded $40.00 to this issue.

vladfrangu commented 5 years ago

Hello!

I'd like to help out with implementing support for BigInt and its Array types. What would I need to do to get started? Just create a PR?

transitive-bullshit commented 5 years ago

Hey @vladfrangu -- your help is very welcome 😄

I'd recommend opening a PR and following the patterns in the code and tests that all of the other types follow. Feel free to open a WIP PR and ask any questions you may have along the way.

Maybe just start with BigInt to keep the PR focused and then add support for the array types in a second pass.

Thanks!

IssueHuntBot commented 5 years ago

@sindresorhus has rewarded $36.00 to @vladfrangu. See it on IssueHunt