sindresorhus / ky

🌳 Tiny & elegant JavaScript HTTP client based on the Fetch API
MIT License
13.62k stars 363 forks source link

Fix flaky browser tests #484

Closed cristobal closed 1 year ago

cristobal commented 1 year ago

The browser tests were flaky due to the reason that the server.close() call was slow sometimes due to open connection kept alive, which is default server behaviour. Resulting in false pending tests assertiions that are actually finished but never finish and times out due to that the server is not closed within the expected timeout.

What's done

NOTES:

sindresorhus commented 1 year ago

Thanks for fixing that 👍

cristobal commented 1 year ago

Thanks for fixing that 👍

Thanks for creating ky 👋🏽