Fix multipart boundary mismatch

sindresorhus / ky

🌳 Tiny & elegant JavaScript HTTP client based on the Fetch API

MIT License

11.91k stars 342 forks source link

Fix multipart boundary mismatch #540

Closed kdelmonte closed 8 months ago

kdelmonte commented 8 months ago

Turns out that the read-only body property of the Request interface is not [yet] supported by Firefox which causes #539.

Changes:

Add functionality to run same test in multiple browsers including Firefox (⚠️ slows down CI by about 1 minute; ~15% slower)
Check Request constructor options explicitly.

Fixes: #539 (introduced in #536)

kdelmonte commented 8 months ago

@sholladay you were correct in your comment when you questioned if all options were being exposed as instance properties. Please let me know what you think about this change.

sindresorhus commented 8 months ago

Thanks for the quick fix 👍