search

sindresorhus / linkify-urls

Linkify URLs in a string
MIT License
160 stars 22 forks source link

Add DocumentFragment alternative return #3

Closed fregante closed 7 years ago

fregante commented 7 years ago

Has minor implementation diff error in the test. I'm not sure of how to test the DocumentFragment.

Fixes #2

fregante commented 7 years ago

😰

screen shot 2017-06-23 at 15 13 13
fregante commented 7 years ago

I found a solution!

fregante commented 7 years ago

What do you prefer? Separate linkifyUrls.getDom method or is an option ok?

sindresorhus commented 7 years ago

Looks good. Option is ok. Could you document it?

sindresorhus commented 7 years ago

🙌