Closed netroy closed 5 years ago
For packages with a default export, use export default foo;, not export = foo;. You will have to add module.exports.default = foo; to the index.js file.
All types used in the public interface should be export'ed.
Don't prefix the name of interfaces with I; Options, not IOptions.
Prefer using the unknown type instead of any whenever possible.
The tests are failing because Object.entries isn't available on node 6.
Don't worry about it. I'll fix that after merging.
@sindresorhus I've made the requested changes. can you have a look at this again?
For packages with a default export, use export default foo;, not export = foo;. You will have to add module.exports.default = foo; to the index.js file.
Not done.
The method should be documented, per https://github.com/sindresorhus/typescript-definition-style-guide#documentation
Ping :)
@sindresorhus do you still plan on implementing this?
I came across this PR when looking at missing types for got
.
// @bendingbender Would you be able to prioritize this package?
The tests are failing because
Object.entries
isn't available on node 6.If you'd like I can send another PR to either change the tests to run for now 8, & 10. Or, I ca send a PR to switch to
Object.keys
instead.Cheers