search

sindresorhus / meow

🐈 CLI app helper
MIT License
3.54k stars 151 forks source link

Rename `camelcase` to `camelCase` #151

Closed ulken closed 4 years ago

ulken commented 4 years ago

Extreme nitpick, but to my knowledge camelcase is spelled camel case and thus camelCase in code. Aligns better with its definition too 😜.

ulken commented 4 years ago

Totally unrelated, but opening a new PR felt like too much:

I find the comments https://github.com/sindresorhus/meow/blob/d963c1f26d04733be5c6e311f0b86971dea8da42/index.js#L198 and https://github.com/sindresorhus/meow/blob/d963c1f26d04733be5c6e311f0b86971dea8da42/index.js#L201 superfluous. Reading the code tells me exactly that.

If you agree, I can remove them.

sindresorhus commented 4 years ago

Can you fix the merge conflict?

sindresorhus commented 4 years ago

I agree about the comments.

ulken commented 4 years ago

Sure. Will do tonight. And remove comments.

ulken commented 4 years ago

@sindresorhus Done