search

sindresorhus / meow

🐈 CLI app helper
MIT License
3.53k stars 150 forks source link

Require Node.js 12 and move to ESM #181

Closed LitoMore closed 3 years ago

LitoMore commented 3 years ago

Fixes #125 Resolves #157 Resolves #176

LitoMore commented 3 years ago

@sindresorhus Do I need to apply this proposal #157 (comment) in current PR?

sindresorhus commented 3 years ago

Do I need to apply this proposal #157 (comment) in current PR?

It doesn't have to be this PR, but it has to be done before what's in this PR can be released.

sindresorhus commented 3 years ago

The TS types are not correctly done. You need to remove the use of namespace and export the individual types.

sindresorhus commented 3 years ago

Please read https://github.com/sindresorhus/meow/pull/181#discussion_r619778517 more closely.

sindresorhus commented 3 years ago

Looks good :)