search

sindresorhus / meow

🐈 CLI app helper
MIT License
3.53k stars 150 forks source link

Remove `trim-newlines` dependency #219

Closed ktschmincke closed 1 year ago

ktschmincke commented 1 year ago

Description

The meow package includes trim-newlines as a dependency (https://github.com/sindresorhus/trim-newlines). This dependency should be removed and the functionality recreated in meow.

Purpose

Reducing dependencies reduces risk overall, and something as simple as trimming newlines should not be pulled in as a dependency.

sindresorhus commented 1 year ago

The package is not a trivial as you may think.

sindresorhus commented 1 year ago

Reducing dependencies reduces risk overall

That's only true if the package comes from a different developer. Since I am the developer of both of this, inlining the dependency actually increases the risk. The package is more likely to receive improvements and security fixes as it has many consumers, while the inlined code will code rot and remain stale.

sindresorhus commented 1 year ago

https://github.com/sindresorhus/meow/issues/67 is a better solution

ktschmincke commented 1 year ago

I clearly didn't look closely enough to realize you were the author of both 😅