sindresorhus / meow

🐈 CLI app helper
MIT License
3.53k stars 150 forks source link

Refactor #233

Open tommy-mitchell opened 1 year ago

tommy-mitchell commented 1 year ago

Per the discussion in https://github.com/sindresorhus/meow/pull/230#issuecomment-1483644249, this is a tracker issue for a general refactor:

tommy-mitchell commented 1 year ago

I also think a rewrite in TypeScript would be beneficial from an ease-of-development perspective. I'd be happy to make a PR, but I understand not wanting to go that route.

sindresorhus commented 1 year ago

The main reason I usually don't want TypeScript is that it introduces a build-step. If - Bundle dependencies ends up requiring a build-step, it may make sense to move to TypeScript.

sindresorhus commented 1 year ago

@tommy-mitchell Should we release a new major version or do you intend to work on more items here?

tommy-mitchell commented 1 year ago

@sindresorhus sorry for the late response, I’ve been busy with work this past week. Probably not going to have much more time for another week or two, so I think we could release now and add e.g. subcommands in a minor version

tommy-mitchell commented 1 year ago

@sindresorhus thoughts on moving to TypeScript, now that we have a build step? We can use Rollup to emit the built JavaScript, and since a build is generated before testing, we can use tsd on the built index.d.ts.

sindresorhus commented 1 year ago

👍