Closed tommy-mitchell closed 1 year ago
This looks good so far 👍
You can target Node.js 16.
Here's what we may be able to take advantage of:
import {setTimeout} from 'node:timers/promises';
import stream from 'node:stream/promises';
AggregateError
.String.prototype.replaceAll
Promise.any
Array/String#at
(Node v16.6.0)Object.hasOwn
(v16.10)(async () => {})()
crypto.randomInt
(Node.js 14.10)import fs from 'node:fs/promises';
crypto.randomUUID()
(Node.js 14.17)signal
option (Node.js 14.18)You can target Node.js 16.
I'll do this in a separate PR then, the diff for this one is already pretty large and I'd like the changes from the improvements to be easier to see.
By the way, is this list posted anywhere else? It's a nice checklist for a project bumping their Node version.
By the way, is this list posted anywhere else? It's a nice checklist for a project bumping their Node version.
It's just my personal list. I think the Node.js team may post something similar on new major versions.
I'll do this in a separate PR then, the diff for this one is already pretty large and I'd like the changes from the improvements to be easier to see.
👍
I've split up associated tests from test.js
into their own files and consolidated via macros or utils where possible, especially for handling fixtures. Some more could be done here, but I think it's good enough for now.
Can you fix the merge conflict?
Should be good now
Per #233.
Tasks:
Miscellaneous fixes:
process.title
, added note to readme/index.d.ts
about overridingoptions.pkg
(needs better wording)