sindresorhus / meow

🐈 CLI app helper
MIT License
3.53k stars 150 forks source link

Separate `index.js` and `test.js` into different files #234

Closed tommy-mitchell closed 1 year ago

tommy-mitchell commented 1 year ago

Per #233.

Tasks:

Miscellaneous fixes:

sindresorhus commented 1 year ago

This looks good so far 👍

sindresorhus commented 1 year ago

You can target Node.js 16.


Here's what we may be able to take advantage of:

Node.js 16

Node.js 14

tommy-mitchell commented 1 year ago

You can target Node.js 16.

I'll do this in a separate PR then, the diff for this one is already pretty large and I'd like the changes from the improvements to be easier to see.

By the way, is this list posted anywhere else? It's a nice checklist for a project bumping their Node version.

sindresorhus commented 1 year ago

By the way, is this list posted anywhere else? It's a nice checklist for a project bumping their Node version.

It's just my personal list. I think the Node.js team may post something similar on new major versions.

sindresorhus commented 1 year ago

I'll do this in a separate PR then, the diff for this one is already pretty large and I'd like the changes from the improvements to be easier to see.

👍

tommy-mitchell commented 1 year ago

I've split up associated tests from test.js into their own files and consolidated via macros or utils where possible, especially for handling fixtures. Some more could be done here, but I think it's good enough for now.

sindresorhus commented 1 year ago

Can you fix the merge conflict?

tommy-mitchell commented 1 year ago

Should be good now