search

sindresorhus / meow

🐈 CLI app helper
MIT License
3.53k stars 150 forks source link

Feature Proposal - Disable Indent #240

Closed dylanarmstrong closed 6 months ago

dylanarmstrong commented 1 year ago

I'd like the option to disable the indent.

  Some descriptive text
  Usage:
    $ application

Is the default, and I'd like to make it indented to 0.

Proposal: Add indent as an option with a default value of 2.

I have submitted a PR for this.

voxpelli commented 1 year ago

Can you give a motivation why you want to have a different indent?

Is it personal taste or it would give some tangible improvements from your point of view?

dylanarmstrong commented 1 year ago

Just personal taste, I prefer that my help descriptions are left aligned in terminal. This adds the ability to adjust it.

voxpelli commented 1 year ago

Lets see what the maintainer thinks then, but just a reflection: There are no other such presentation options in Meow currently, and I'm personally not sure if it would be good to open that box of making presentation customizable to personal taste. Lots of options for little gain?

dylanarmstrong commented 1 year ago

Interesting, I hadn’t actually realized.

How frequently do they check PRs? I have another one against node-defaults too.

sindresorhus commented 12 months ago

Accepted.

/* @default 2 */
indentHelp: number | false
sindresorhus commented 12 months ago

How frequently do they check PRs? I have another one against node-defaults too.

Every day, but I have been at bit overwhelmed with pull request during the summer.

sindresorhus commented 12 months ago

indentHelp or helpIndent? I think indent is too ambigious. We don't indent --version, for example.

voxpelli commented 12 months ago

helpIndent I would say

ons 30 aug. 2023 kl. 09:03 skrev Sindre Sorhus @.***>:

indentHelp or helpIndent? I think indent is too ambigious. We don't indent --version, for example.

— Reply to this email directly, view it on GitHub https://github.com/sindresorhus/meow/issues/240#issuecomment-1698609136, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAINGOZCVI7PWQYHI3N4WTXX3QTHANCNFSM6AAAAAAZATXTLA . You are receiving this because you commented.Message ID: @.***>

dylanarmstrong commented 12 months ago

Thanks, I've updated PR to helpIndent and rebased against main.

Oops, apologies @sindresorhus, just realized that in your example you used indentHelp. I'm fine with either, which would you prefer?

sindresorhus commented 12 months ago

Let's go with helpIndent.

dylanarmstrong commented 9 months ago

Just to clarify, this was updated in the PR.

dylanarmstrong commented 6 months ago

Hi, have you had a chance to look at the PR?