Rewrite in TypeScript

[tommy-mitchell]

Per #233.

• Augmented the types from minimist-options to support the arguments option (see minimist-options.d.ts)
  • I wanted to upstream these changes, but I ran into microsoft/TypeScript#17867 (SO thread)
  • Not sure why it's working here but not when I make the changes to minimist-options itself
• Related, I kept running into that issue with other types as well, such as the -- option in flags

[tommy-mitchell]

May have missed some comments, but that's the bulk of where I'm needing clarification. The other TODOs I have are reminders to fix type issues.

[sindresorhus]

FYI: https://github.com/sindresorhus/meow/commit/e9a55cdd748d3f451c761c46eba1cfb7ca862dbe

[tommy-mitchell]

Do we support a shorthand for setting flags?

const cli = meow({
    importMeta: import.meta
    flags: {
        rainbow: 'boolean',
        unicorn: 'string',
    },
});

[sindresorhus]

Do we support a shorthand for setting flags?

No. That's not something I want to support either.

[tommy-mitchell]

Got it. I think this test case (and maybe another?) had confused me before and I was remembering something about it:

https://github.com/sindresorhus/meow/blob/c97c03161753f611798996978e8274323c004382/test/errors.js#L38-L40

[sindresorhus]

That test case is incorrect.

[tommy-mitchell]

Updated to reflect changes from other PRs. Type tests are failing due to tsd not seeing minimist-options.d.ts.

[tommy-mitchell]

CI is failing due to https://github.com/sindresorhus/type-fest/pull/824

[tommy-mitchell]

I'm not sure how to fix the timeout issue, I get it sometimes locally when running npm test but never with npx ava.

[sindresorhus]

Maybe try downgrading to ava@5 for now.

[tommy-mitchell]

Didn't work, guess it's something on our end. Now it doesn't even say which test timed out.

[sindresorhus]

Works for me now: https://github.com/sindresorhus/meow/pull/252/commits/64f0915b8aa0ed42b9a04fc4bc7b814e125b57d3

[sindresorhus]

Hmm, or maybe not. Maybe the problem here is tsimp. I never had any problems with tsx. Maybe worth trying that.