search

sindresorhus / normalize-url

Normalize a URL
MIT License
837 stars 123 forks source link

Fix Safari compatibility for version 6.1.0 #168

Closed omry-hay closed 2 years ago

omry-hay commented 2 years ago

We are using version v6.1.0 and can't upgrade since we still can't use pure ESM. However this version is incompatible with Safari, and we are kind of stuck here. Can you please release a new version with the fix for version 6.1.0?

hmelenok commented 2 years ago

Not an excuse or anything but: CleanShot 2022-08-18 at 19 02 55

And usage stats show how much people stuck with 4.5.1: CleanShot 2022-08-18 at 19 02 30

hmelenok commented 2 years ago

The problem is in unsupported by Safari regex patterns 

SyntaxError: Invalid regular expression: invalid group specifier name

https://stackoverflow.com/questions/51568821/works-in-chrome-but-breaks-in-safari-invalid-regular-expression-invalid-group

sindresorhus commented 2 years ago

https://github.com/sindresorhus/normalize-url/pull/170#issuecomment-1234134039